<html>
<head><meta charset="utf-8"><title>--keep-going? · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html">--keep-going?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="246668112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246668112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246668112">(Jul 21 2021 at 00:53)</a>:</h4>
<p>is there a way to tell <code>cargo clippy</code> to not bail out on an error?</p>
<p><a href="https://github.com/BurntSushi/ripgrep">https://github.com/BurntSushi/ripgrep</a> HEAD passes <code>cargo check</code> and <code>cargo build</code> just fine but has a finding that causes clippy to- at least this is what i think it's doing- bail out before it finishes linting the repo</p>



<a name="246668172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246668172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246668172">(Jul 21 2021 at 00:54)</a>:</h4>
<p>which means that i can't be sure if <code>clippy</code> is actually telling me what the full set of lint findings is</p>



<a name="246668623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246668623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246668623">(Jul 21 2021 at 01:02)</a>:</h4>
<p><span class="user-mention silent" data-user-id="427707">Sam Lijin</span> <a href="#narrow/stream/257328-clippy/topic/--keep-going.3F/near/246668112">said</a>:</p>
<blockquote>
<p>is there a way to tell <code>cargo clippy</code> to not bail out on an error?</p>
<p><a href="https://github.com/BurntSushi/ripgrep">https://github.com/BurntSushi/ripgrep</a> HEAD passes <code>cargo check</code> and <code>cargo build</code> just fine but has a finding that causes clippy to- at least this is what i think it's doing- bail out before it finishes linting the repo</p>
</blockquote>
<p>I think <code>warn(warnings)</code> might do it? untested though</p>



<a name="246668664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246668664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246668664">(Jul 21 2021 at 01:02)</a>:</h4>
<p>if not, you can always <code>warn(the_lint_that_errors)</code></p>



<a name="246669050"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669050" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669050">(Jul 21 2021 at 01:09)</a>:</h4>
<blockquote>
<p>I think warn(warnings) might do it? untested though</p>
</blockquote>
<p>gotcha, but not supported directly in clippy</p>
<p>any chance you know if there's a particular reason this is the case? or is this (most likely) just how it happened to be implemented</p>



<a name="246669126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669126">(Jul 21 2021 at 01:10)</a>:</h4>
<blockquote>
<p>gotcha, but not supported directly in clippy</p>
</blockquote>
<p>what do you mean? you can put it directly in the source code. I think there's even a <code>cfg(clippy)</code> so it only applies to clippy warnings.</p>



<a name="246669212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669212">(Jul 21 2021 at 01:12)</a>:</h4>
<p>i guess i'm looking for a way to preserve not only the lint warnings but also their relative severity</p>



<a name="246669226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669226">(Jul 21 2021 at 01:12)</a>:</h4>
<p>that definitely does not exist and it would be quite difficult to add</p>



<a name="246669236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669236">(Jul 21 2021 at 01:13)</a>:</h4>
<p>right now lots of the compiler depends on errors actually halting compilation</p>



<a name="246669247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669247">(Jul 21 2021 at 01:13)</a>:</h4>
<p>depends on lint errors halting compilation?</p>



<a name="246669250"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669250" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669250">(Jul 21 2021 at 01:13)</a>:</h4>
<p>to be clear: ripgrep <code>cargo build</code> succeeds at HEAD</p>



<a name="246669277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669277">(Jul 21 2021 at 01:14)</a>:</h4>
<p>maybe not lints specifically. I guess it does already distinguish lints from errors from hard errors because it silences lint errors for dependencies</p>



<a name="246669325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669325">(Jul 21 2021 at 01:14)</a>:</h4>
<p>but changing this for lints that would be a larger change than just changing clippy</p>



<a name="246669327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669327">(Jul 21 2021 at 01:14)</a>:</h4>
<p>since the compiler also has its own lints</p>



<a name="246669330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669330">(Jul 21 2021 at 01:14)</a>:</h4>
<p>it makes sense that linting a malformed AST would be a little hard, since that's an open research problem :p</p>



<a name="246669361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669361">(Jul 21 2021 at 01:15)</a>:</h4>
<p>oh, so some lints are actually enforced in <code>rustc</code> itself as opposed to <code>clippy</code>?</p>



<a name="246669394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669394">(Jul 21 2021 at 01:16)</a>:</h4>
<p>what about the less generic case: just some kind of <code>--keep-going</code> for <code>clippy</code>-defined lints?</p>



<a name="246669448"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669448" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669448">(Jul 21 2021 at 01:16)</a>:</h4>
<p>that would actually be harder than doing it for all lints</p>



<a name="246669459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669459">(Jul 21 2021 at 01:16)</a>:</h4>
<p>since the compiler would have to start special-casing clippy</p>



<a name="246669471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669471">(Jul 21 2021 at 01:17)</a>:</h4>
<p>ah</p>



<a name="246669472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669472">(Jul 21 2021 at 01:17)</a>:</h4>
<p>right now clippy is "just" a tool using rustc_private, it's not special-cased like rustdoc</p>



<a name="246669481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669481">(Jul 21 2021 at 01:17)</a>:</h4>
<p>/me is not happy that rustdoc is special cased so much</p>



<a name="246669484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669484">(Jul 21 2021 at 01:17)</a>:</h4>
<p>oh, are lints implemented by feeding boolean conditions into <code>rustc</code> basically?</p>



<a name="246669493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669493">(Jul 21 2021 at 01:17)</a>:</h4>
<p>not really? the lints go through rustc_lint though</p>



<a name="246669495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669495">(Jul 21 2021 at 01:17)</a>:</h4>
<p>(i'm new to rust, so kinda just reverse engineering my way through the black box right now)</p>



<a name="246669498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669498">(Jul 21 2021 at 01:17)</a>:</h4>
<p>err I guess rustc_errors is more relevant for this conversation</p>



<a name="246669556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669556">(Jul 21 2021 at 01:18)</a>:</h4>
<p>it might help to read an example lint: <a href="https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/methods/bytes_nth.rs">https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/methods/bytes_nth.rs</a></p>



<a name="246669665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669665">(Jul 21 2021 at 01:20)</a>:</h4>
<p>gotcha- i guess once i have a better mental model of rustc itself this will make more sense</p>



<a name="246669691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669691">(Jul 21 2021 at 01:21)</a>:</h4>
<p>FWIW I do think it's a reasonable change to keep going on deny-by-default lints, and only error at the end</p>



<a name="246669745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669745">(Jul 21 2021 at 01:22)</a>:</h4>
<p>but that still wouldn't achieve your goal because cargo wouldn't continue to lint downstream crates that depend on this crate, because of the error</p>



<a name="246669757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669757">(Jul 21 2021 at 01:22)</a>:</h4>
<p>is there an issue tracker somewhere i could put that suggestion?</p>



<a name="246669759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669759">(Jul 21 2021 at 01:22)</a>:</h4>
<p>rust-lang/rust is the best place I think</p>



<a name="246669777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669777">(Jul 21 2021 at 01:23)</a>:</h4>
<blockquote>
<p>but that still wouldn't achieve your goal because cargo wouldn't continue to lint downstream crates that depend on this crate, because of the error</p>
</blockquote>
<p>oh, so there would need to be another level of crate-after-crate linting?</p>



<a name="246669831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669831">(Jul 21 2021 at 01:24)</a>:</h4>
<p>yeah, it would need cargo integration somehow, it would be a little tricky I think</p>



<a name="246669840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669840">(Jul 21 2021 at 01:24)</a>:</h4>
<p>the compiler would need to start distinguishing "lint-only errors" in the <em>output</em>, which it definitely doesn't do currently</p>



<a name="246669860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246669860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246669860">(Jul 21 2021 at 01:25)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/257328-clippy/topic/--keep-going.3F/near/246669745">said</a>:</p>
<blockquote>
<p>but that still wouldn't achieve your goal because cargo wouldn't continue to lint downstream crates that depend on this crate, because of the error</p>
</blockquote>
<p>this comes up for path dependencies (I think that's the only place where cargo doesn't use --cap-lints allow)</p>



<a name="246670185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246670185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246670185">(Jul 21 2021 at 01:31)</a>:</h4>
<p>(for your use case I would definitely just <code>warn(...)</code> for now)</p>



<a name="246670262"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246670262" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246670262">(Jul 21 2021 at 01:32)</a>:</h4>
<p>yep, totally</p>



<a name="246670404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246670404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sam Lijin <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246670404">(Jul 21 2021 at 01:35)</a>:</h4>
<p>filed <a href="https://github.com/rust-lang/rust/issues/87334">https://github.com/rust-lang/rust/issues/87334</a> - thanks for the guidance! (i would tag you but i don't know your GH handle)</p>



<a name="246670409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246670409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246670409">(Jul 21 2021 at 01:36)</a>:</h4>
<p>I'm @jyn514</p>



<a name="246670564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246670564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246670564">(Jul 21 2021 at 01:38)</a>:</h4>
<p>thanks for your patience :) sometimes people get frustrated when they realize that things are complicated <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span> I appreciate you listening</p>



<a name="246670933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246670933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246670933">(Jul 21 2021 at 01:45)</a>:</h4>
<p>/me is deciding between getting distracted by this and finally implementing <a href="https://github.com/rust-lang/rust/pull/86022">https://github.com/rust-lang/rust/pull/86022</a></p>



<a name="246671929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246671929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246671929">(Jul 21 2021 at 02:03)</a>:</h4>
<p>screw it this seems fun</p>



<a name="246672448"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246672448" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246672448">(Jul 21 2021 at 02:11)</a>:</h4>
<p>aha, so what's going on is that there are specific parts of the compiler calling <code>abort_if_errors</code> (presumably because they aren't able to deal with broken code), and the handler tells them if there was <em>any</em> error, including lint errors</p>



<a name="246672536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246672536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246672536">(Jul 21 2021 at 02:12)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/blob/b41936b92cd8463020207cb2f62a4247942ef2e4/compiler/rustc_errors/src/lib.rs#L866-L870">https://github.com/rust-lang/rust/blob/b41936b92cd8463020207cb2f62a4247942ef2e4/compiler/rustc_errors/src/lib.rs#L866-L870</a></p>



<a name="246673435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246673435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246673435">(Jul 21 2021 at 02:30)</a>:</h4>
<blockquote>
<p>error: aborting due to 89 previous errors</p>
</blockquote>
<p>oh boy</p>



<a name="246675860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246675860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246675860">(Jul 21 2021 at 03:26)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/87337">https://github.com/rust-lang/rust/pull/87337</a></p>



<a name="246691768"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246691768" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246691768">(Jul 21 2021 at 08:25)</a>:</h4>
<p>If you don't want the compiler to abort on a deny-by-default lint, then you can just use <code>--cap-lints=warn</code>. Preserving the lint levels and keep going even if there is an error, makes lint levels completely nonsensical. </p>
<p>IMO not aborting after an error, even with lints, is a bad idea. Here's why:</p>
<p>The compiler works in stages / IRs and so do lints. So there is the AST, where source-level checks are done, the (T)HIR where type checking and similar things happen and the MIR, where borrow checking and the like happen. If you already have erroneous code at the source-level AST, then you should fix those first, before the linter tries to check type information or borrowing stuff. </p>
<p>Making the compiler not stop after an error would render different lint levels useless. The only difference then would be that they have a different color in the terminal. </p>
<p>So I'm against this change, especially since there already is the <code>--cap-lints</code> flag where you can tell the compiler to ignore all lint levels above a specific level.</p>



<a name="246713208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246713208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246713208">(Jul 21 2021 at 12:42)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> why are stages useful to the end user, though? There's an issue open from like 2015 to still show borrowck errors even if there are type errors.</p>
<p>This will still exit with an error status if there are lint errors, it will just show all the lints before exiting.</p>



<a name="246713443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246713443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246713443">(Jul 21 2021 at 12:44)</a>:</h4>
<p>Yeah, maybe my concerns are a bit unwarranted.  I posted a comment about this on your PR.</p>



<a name="246714295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246714295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246714295">(Jul 21 2021 at 12:51)</a>:</h4>
<p>(pushing the blessed tests now so you can see exaclty what changed)</p>



<a name="246714429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246714429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246714429">(Jul 21 2021 at 12:52)</a>:</h4>
<p>oh ugh I continue to create my own problems, they were blessed wrong because I have rustup env variables set</p>



<a name="246714434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246714434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246714434">(Jul 21 2021 at 12:52)</a>:</h4>
<p>I need to fix that in bootstrap</p>



<a name="246726394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246726394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246726394">(Jul 21 2021 at 14:21)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> how are you running the tests? I'm getting "multiple rlibs for crate" again</p>



<a name="246726570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246726570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246726570">(Jul 21 2021 at 14:22)</a>:</h4>
<p>Just delete <code>build/&lt;target&gt;/stage1-tools</code> and rerun <code>./x.py test src/tools/clippy</code></p>



<a name="246726622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246726622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246726622">(Jul 21 2021 at 14:22)</a>:</h4>
<p>that didn't work, I got the same error :/</p>



<a name="246726717"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246726717" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246726717">(Jul 21 2021 at 14:23)</a>:</h4>
<p>ok I deleted a couple .rlib files manualy and that seemed to do it</p>



<a name="246726851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246726851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246726851">(Jul 21 2021 at 14:24)</a>:</h4>
<p>is there a way for clippy's compiletest to only show a summary of the failures? this is really hard to read:</p>
<div class="codehilite"><pre><span></span><code>------------------------------------------

diff of stderr:

 error: the type of the `self` parameter does not need to be arbitrary
   --&gt; $DIR/needless_arbitrary_self_type_unfixable.rs:41:31
    |
 LL |         fn call_with_mut_self(self: &amp;mut Self) {}
    |                               ^^^^^^^^^^^^^^^ help: consider to change this parameter to: `&amp;&#39;_ mut self`
    |
    = note: `-D clippy::needless-arbitrary-self-type` implied by `-D warnings`

-error: aborting due to previous error
+error: explicit lifetimes given in parameter types where they could be elided (or replaced with `&#39;_` if needed by type declaration)
+  --&gt; $DIR/needless_arbitrary_self_type_unfixable.rs:41:9
+   |
+LL |         fn call_with_mut_self(self: &amp;mut Self) {}
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
+
+error: aborting due to 2 previous errors



The actual stderr differed from the expected stderr.
Actual stderr saved to /home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/release/test_build_base/needless_arbitrary_self_type_unfixable.stage-id.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args needless_arbitrary_self_type_unfixable.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: &quot;/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools-bin/clippy-driver&quot; &quot;tests/ui/needless_arbitrary_self_type_unfixable.rs&quot; &quot;-L&quot; &quot;/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/release/test_build_base&quot; &quot;--target=x86_64-unknown-linux-gnu&quot; &quot;--error-format&quot; &quot;json&quot; &quot;-C&quot; &quot;prefer-dynamic&quot; &quot;-o&quot; &quot;/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/release/test_build_base/needless_arbitrary_self_type_unfixable.stage-id&quot; &quot;-A&quot; &quot;unused&quot; &quot;--emit=metadata&quot; &quot;-L&quot; &quot;/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps&quot; &quot;-L&quot; &quot;/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps&quot; &quot;-Dwarnings&quot; &quot;-Zui-testing&quot; &quot;--extern&quot; &quot;serde=/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libserde-4e004c5cead5444c.rlib&quot; &quot;--extern&quot; &quot;syn=/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-7d26d4702984e728.rlib&quot; &quot;--extern&quot; &quot;clippy_lints=/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-78d172c13182c4db.rlib&quot; &quot;--extern&quot; &quot;quote=/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libquote-ca5f069fbd18092a.rlib&quot; &quot;--extern&quot; &quot;regex=/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libregex-3ffeac914dbf6a42.rlib&quot; &quot;-L&quot; &quot;/home/joshua/rust/build/x86_64-unknown-linux-gnu/stage1-tools/release/test_build_base/needless_arbitrary_self_type_unfixable.stage-id.aux&quot;
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
{&quot;message&quot;:&quot;the type of the `self` parameter does not need to be arbitrary&quot;,&quot;code&quot;:{&quot;code&quot;:&quot;clippy::needless_arbitrary_self_type&quot;,&quot;explanation&quot;:null},&quot;level&quot;:&quot;error&quot;,&quot;spans&quot;:[{&quot;file_name&quot;:&quot;tests/ui/needless_arbitrary_self_type_unfixable.rs&quot;,&quot;byte_start&quot;:1038,&quot;byte_end&quot;:1053,&quot;line_start&quot;:41,&quot;line_end&quot;:41,&quot;column_start&quot;:31,&quot;column_end&quot;:46,&quot;is_primary&quot;:true,&quot;text&quot;:[{&quot;text&quot;:&quot;        fn call_with_mut_self(self: &amp;mut Self) {}&quot;,&quot;highlight_start&quot;:31,&quot;highlight_end&quot;:46}],&quot;label&quot;:null,&quot;suggested_replacement&quot;:null,&quot;suggestion_applicability&quot;:null,&quot;expansion&quot;:null}],&quot;children&quot;:[{&quot;message&quot;:&quot;`-D clippy::needless-arbitrary-self-type` implied by `-D warnings`&quot;,&quot;code&quot;:null,&quot;level&quot;:&quot;note&quot;,&quot;spans&quot;:[],&quot;children&quot;:[],&quot;rendered&quot;:null},{&quot;message&quot;:&quot;consider to change this parameter to&quot;,&quot;code&quot;:null,&quot;level&quot;:&quot;help&quot;,&quot;spans&quot;:[{&quot;file_name&quot;:&quot;tests/ui/needless_arbitrary_self_type_unfixable.rs&quot;,&quot;byte_start&quot;:1038,&quot;byte_end&quot;:1053,&quot;line_start&quot;:41,&quot;line_end&quot;:41,&quot;column_start&quot;:31,&quot;column_end&quot;:46,&quot;is_primary&quot;:true,&quot;text&quot;:[{&quot;text&quot;:&quot;        fn call_with_mut_self(self: &amp;mut Self) {}&quot;,&quot;highlight_start&quot;:31,&quot;highlight_end&quot;:46}],&quot;label&quot;:null,&quot;suggested_replacement&quot;:&quot;&amp;&#39;_ mut self&quot;,&quot;suggestion_applicability&quot;:&quot;HasPlaceholders&quot;,&quot;expansion&quot;:null}],&quot;children&quot;:[],&quot;rendered&quot;:null}],&quot;rendered&quot;:&quot;error: the type of the `self` parameter does not need to be arbitrary\n  --&gt; tests/ui/needless_arbitrary_self_type_unfixable.rs:41:31\n   |\nLL |         fn call_with_mut_self(self: &amp;mut Self) {}\n   |                               ^^^^^^^^^^^^^^^ help: consider to change this parameter to: `&amp;&#39;_ mut self`\n   |\n   = note: `-D clippy::needless-arbitrary-self-type` implied by `-D warnings`\n\n&quot;}
{&quot;message&quot;:&quot;explicit lifetimes given in parameter types where they could be elided (or replaced with `&#39;_` if needed by type declaration)&quot;,&quot;code&quot;:{&quot;code&quot;:&quot;clippy::needless_lifetimes&quot;,&quot;explanation&quot;:null},&quot;level&quot;:&quot;error&quot;,&quot;spans&quot;:[{&quot;file_name&quot;:&quot;tests/ui/needless_arbitrary_self_type_unfixable.rs&quot;,&quot;byte_start&quot;:1016,&quot;byte_end&quot;:1055,&quot;line_start&quot;:41,&quot;line_end&quot;:41,&quot;column_start&quot;:9,&quot;column_end&quot;:48,&quot;is_primary&quot;:true,&quot;text&quot;:[{&quot;text&quot;:&quot;        fn call_with_mut_self(self: &amp;mut Self) {}&quot;,&quot;highlight_start&quot;:9,&quot;highlight_end&quot;:48}],&quot;label&quot;:null,&quot;suggested_replacement&quot;:null,&quot;suggestion_applicability&quot;:null,&quot;expansion&quot;:null}],&quot;children&quot;:[{&quot;message&quot;:&quot;`-D clippy::needless-lifetimes` implied by `-D warnings`&quot;,&quot;code&quot;:null,&quot;level&quot;:&quot;note&quot;,&quot;spans&quot;:[],&quot;children&quot;:[],&quot;rendered&quot;:null}],&quot;rendered&quot;:&quot;error: explicit lifetimes given in parameter types where they could be elided (or replaced with `&#39;_` if needed by type declaration)\n  --&gt; tests/ui/needless_arbitrary_self_type_unfixable.rs:41:9\n   |\nLL |         fn call_with_mut_self(self: &amp;mut Self) {}\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`\n\n&quot;}
{&quot;message&quot;:&quot;aborting due to 2 previous errors&quot;,&quot;code&quot;:null,&quot;level&quot;:&quot;error&quot;,&quot;spans&quot;:[],&quot;children&quot;:[],&quot;rendered&quot;:&quot;error: aborting due to 2 previous errors\n\n&quot;}

------------------------------------------

thread &#39;compile_test&#39; panicked at &#39;Some tests failed&#39;, /home/joshua/.local/lib/cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.6.0/src/lib.rs:105:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    compile_test
</code></pre></div>



<a name="246726900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246726900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246726900">(Jul 21 2021 at 14:24)</a>:</h4>
<p>anyway I'm out of time for this for now</p>



<a name="246727244"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246727244" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246727244">(Jul 21 2021 at 14:27)</a>:</h4>
<p>Just the summary, I don't think so. </p>
<div class="codehilite"><pre><span></span><code>failures:
    [ui] ui/crashes/ice-3969.rs
    [ui] ui/deref_addrof.rs
    [ui] ui/double_neg.rs
    [ui] ui/fn_params_excessive_bools.rs
    [ui] ui/formatting.rs
    [ui] ui/literals.rs
    [ui] ui/many_single_char_names.rs
    [ui] ui/mistyped_literal_suffix.rs
    [ui] ui/needless_arbitrary_self_type_unfixable.rs
    [ui] ui/needless_continue.rs
    [ui] ui/non_expressive_names.rs
    [ui] ui/redundant_closure_call_early.rs
    [ui] ui/redundant_else.rs
    [ui] ui/similar_names.rs
    [ui] ui/suspicious_else_formatting.rs
    [ui] ui/suspicious_operation_groupings.rs

test result: FAILED. 632 passed; 16 failed; 3 ignored; 0 measured; 0 filtered out; finished in 9.06s
</code></pre></div>
<p>Here's the summary</p>



<a name="246727642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/--keep-going%3F/near/246727642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/--keep-going.3F.html#246727642">(Jul 21 2021 at 14:30)</a>:</h4>
<p>And here is a gist of how it would look like if you'd just bless the Clippy tests: <a href="https://gist.github.com/flip1995/6debf3da5d2dd9244d795ec51f529398">https://gist.github.com/flip1995/6debf3da5d2dd9244d795ec51f529398</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>